Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: pr-label script run in 3min+ (instead of few seconds) #2185

Closed
kpanot opened this issue Sep 20, 2024 · 0 comments · Fixed by #2186
Closed

[Bug]: pr-label script run in 3min+ (instead of few seconds) #2185

kpanot opened this issue Sep 20, 2024 · 0 comments · Fixed by #2186
Assignees
@matthieu-crouzet
Labels
bug Something isn't working priority:low

Comments

@kpanot
Copy link
Contributor

kpanot commented Sep 20, 2024

Package name

  • global -

Package version

11.2.0

Reproduction steps

Create a PR with a single commit (which will trigger the pipeline)

Current result

the pr-label workflow run in 4min+ because of the script pr-label is taking 3min+

Expected result

The script pr-label is taking 3min+ to run in few seconds when the changelog does not contains many commits.

Additional comments

No response
@kpanot kpanot added bug Something isn't working triage labels Sep 20, 2024
@matthieu-crouzet matthieu-crouzet self-assigned this Sep 20, 2024
@matthieu-crouzet matthieu-crouzet mentioned this issue Sep 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 23, 2024
@matthieu-crouzet
fix(pr-labels): reduce the time to find touched projects (#2186)
557904d 
## Proposed change
Reduce the number of spawn used, thanks to [nx graph
command](https://nx.dev/nx-api/nx/documents/dep-graph#graph)
Not using `--print` because it's not working anymore
nrwl/nx#27682

## Related issues

- 🐛 Fixes #2185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthieu-crouzet matthieu-crouzet

Labels
bug Something isn't working priority:low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pr-labels): reduce the time to find touched projects AmadeusITGroup/otter
2 participants
@kpanot @matthieu-crouzet