Make amc::vector declaration work with incomplete types like std::vector #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanel
force-pushed
the
feature/amcvectorincompletetype
branch
from
8768eec to
4f233ee
Compare
sjanel
force-pushed
the
feature/amcvectorincompletetype
branch
from
4f233ee to
2d9ae6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At instantiation of
amc::vectorwith an incomplete type, there was a compiler error as we try to access tosizeof(T)andstd::is_trivially_destructible<T>, unlikestd::vectorwhich works fine (and is defined standard behavior from C++17).This PR makes it possible to use
amc::vectorwith incomplete types.