WIP: favor maps over lists due to helm list merge limitations #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmsurpre
changed the title
lmsurpre
force-pushed
the
lee-main-2
branch
4 times, most recently
from
6f79c97 to
c51970f
Compare
Originally, I went with an approach that uses lists of objects. However, after experiencing some pain with the helm support for combining / overriding lists, I reverted back to a map-based approach where the key-names have more value. This is more consistent with the approach we use in fhir-server-config anyway, and so I went ahead and made them exactly alike so that we can just rely on helm's toJson instead of writing our own templates for this. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
…sactionTimeout Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
|
closing this in favor of #70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, I went with an approach that uses lists of objects.
However, after experiencing some pain with the helm support for combining / overriding lists,
I reverted back to a map-based approach where the key-names are kind of part of the value.
This is more consistent with the approach we use in fhir-server-config anyway, and so
I went ahead and made them exactly alike so that we can just rely on helm's toJson instead of
writing our own templates for this.
NOTE: Due to the fact that the helm toYaml implementation adds properties with a value of null,
this change relies on FHIR Server versions that include the following changeset:
LinuxForHealth/FHIR#2822
Please don't merge until that is released.
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com