log: merge MAIN_LOG() into G_LOG() #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit drops MAIN_LOG() and makes calling G_LOG() in non-lcore contexts safe because it is very error prone to identify when one should use MAIN_LOG() instead of G_LOG(). For example, lib/net.c:lsc_event_callback(), which runs in a non-lcore context, calls log_if_name(). But log_if_name() uses G_LOG() because it is also called in lcore contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit drops
MAIN_LOG()and makes callingG_LOG()in non-lcore contexts safe because it is very error prone to identify when one should useMAIN_LOG()instead ofG_LOG(). For example,lib/net.c:lsc_event_callback(), which runs in a non-lcore context, callslog_if_name(). Butlog_if_name()usesG_LOG()because it is also called in lcore contexts.