gk: convert all batched lookups into coroutines #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AltraMayor
commented
Nov 7, 2019
mengxiang0811
requested changes
Nov 8, 2019
mengxiang0811
requested changes
Nov 8, 2019
mengxiang0811
requested changes
Nov 9, 2019
|
The code has incorporated all the feedback. |
AltraMayor
force-pushed
the
gk_co
branch
2 times, most recently
from
ce44b94 to
a93ecb0
Compare
mengxiang0811
requested changes
Nov 11, 2019
|
This pull request needs to resolve the conflicts. |
AltraMayor
force-pushed
the
gk_co
branch
4 times, most recently
from
547c8a1 to
cb555c1
Compare
Library CORO implements coroutines.
AltraMayor
force-pushed
the
gk_co
branch
5 times, most recently
from
eac1227 to
da3a660
Compare
|
Below is the performance evaluation of the master branch with our updated scripts: |
|
Below is the performance evaluation after applying this pull request: |
|
Below is the CPU cycles profiling with 3 lcores + 2^25 flow entries: Below is the memory loads profiling with 3 lcores + 2^25 flow entries: Below is the stats with 3 lcores + 2^25 flow entries: Note that the above profiling results are after applying the pull request. |
This patch gets everything set up to do the work of gk_proc() inside coroutines, but no work is actually moved into coroutines. The following patches gradually move the work of gk_proc() into coroutines.
|
Below is the performance evaluation after applying the latest updated pull request: Below is the CPU cycles profiling with 3 lcores + 2^25 flow entries: Below is the memory loads profiling with 3 lcores + 2^25 flow entries: Below is the stats with 3 lcores + 2^25 flow entries: |
This patch moves the following work to coroutines: 1. scanning of the flow table; 2. processing of front packets. Besides moving the processing of front packets to coroutines this patch streamlines the code to better fit the new model. For example, this patch simplifies the parameters of process_flow_entry() and its subordinate functions: gk_process_request(), gk_process_granted(), gk_process_declined(), and gk_process_bpf().
This patch prefetches the transmission fields of a packet when it is ready to be prepared for transmission.
AltraMayor
force-pushed
the
master
branch
4 times, most recently
from
436ab22 to
e52bbf2
Compare
AltraMayor
commented
Jun 27, 2024
Comment on lines
+1541
to
+1542
| if (likely(has_rss)) { | ||
| task->task_hash = pkt->hash.rss; |
There was a problem hiding this comment.
We must rewrite pkt->hash.rss with pkt->hash.rss >> rss_bits, where rss_bits is pkt->hash.rss are constant for a given GK instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GK blocks batch lookups to the flow table and the LPM table. This pull request reverts these batched lookups back to single lookups and moves the code into coroutines.