Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate #define of KNI_FIFO_COUNT_MAX #481

Closed
AltraMayor opened this issue May 24, 2021 · 1 comment
Closed

Avoid duplicate #define of KNI_FIFO_COUNT_MAX #481

AltraMayor opened this issue May 24, 2021 · 1 comment
Labels
enhancement
Milestone
Version 1.2

Comments

@AltraMayor
Copy link
Owner

According to the documentation of rte_kni_alloc(), each KNI interface needs at least 2 x KNI_FIFO_COUNT_MAX packets. But the define KNI_FIFO_COUNT_MAX is not exported.

Once KNI_FIFO_COUNT_MAX is exported, avoid duplicate #define of it.
@AltraMayor AltraMayor added this to the DPDK coordination milestone May 24, 2021
AltraMayor added a commit that referenced this issue Mar 1, 2024
@AltraMayor
cps: replace DPDK's KNI library with virtio-user
f23b7ef 
DPDK dropped its KNI library at version 23.11.
This commit replaces DPDK's KNI library with virtio-user.

This commit closes #481, closes #570, closes #585, closes #674.
AltraMayor added a commit that referenced this issue Mar 1, 2024
@AltraMayor
cps: replace DPDK's KNI library with virtio-user
53e42db 
DPDK dropped its KNI library at version 23.11.
This commit replaces DPDK's KNI library with virtio-user.

This commit closes #481, closes #570, closes #585, closes #674.
@AltraMayor
Copy link
Owner Author

Pull request #678 eliminated the need for the define KNI_FIFO_COUNT_MAX.

@AltraMayor AltraMayor mentioned this issue Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Version 1.2
Development

No branches or pull requests
1 participant
@AltraMayor