Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: text disappearing from description and help text #13656

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: text disappearing from description and help text #13656

wants to merge 2 commits into from

Conversation

JamalAlabdullah
Copy link
Contributor

Description

  • Added hook to get the text value from textResource
  • Updated useState in Texresource component to use the hook.
  • Added test.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@JamalAlabdullah JamalAlabdullah linked an issue Sep 27, 2024 that may be closed by this pull request
Closing the description or the help text of an option removes the associated text link #13483
Open
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Sep 27, 2024
@JamalAlabdullah JamalAlabdullah changed the title fix text disappearing from description and help text fix: text disappearing from description and help text Sep 27, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.10%. Comparing base (8b4aa15) to head (0db2b18).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13656      +/-   ##
==========================================
- Coverage   95.23%   94.10%   -1.14%     
==========================================
  Files        1502     1501       -1     
  Lines       20567    20563       -4     
  Branches     2492     2490       -2     
==========================================
- Hits        19588    19351     -237     
- Misses        869      954      +85     
- Partials      110      258     +148

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JamalAlabdullah
JamalAlabdullah commented Sep 27, 2024
View reviewed changes
frontend/packages/ux-editor/src/components/TextResource/hooks/useGetTextResourceValue.test.ts
...props,
};

return renderHook(() => useGetTextResourceValue(allProps.id), {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tips to use ServiceContextProvider in better way ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closing the description or the help text of an option removes the associated text link
1 participant
@JamalAlabdullah