Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upload static images to be used by the image component #13322

Merged
merged 40 commits into from
Sep 27, 2024
Merged

feat: upload static images to be used by the image component #13322

merged 40 commits into from
Sep 27, 2024

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Aug 7, 2024 •
edited
Loading

Description

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@standeren standeren linked an issue Aug 7, 2024 that may be closed by this pull request
Upload static images to be used by the Image component #12848
Closed
8 tasks
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Aug 7, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.24%. Comparing base (d32522e) to head (46f1d65).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13322      +/-   ##
==========================================
- Coverage   95.24%   94.24%   -1.01%     
==========================================
  Files        1505     1531      +26     
  Lines       20589    20885     +296     
  Branches     2492     2521      +29     
==========================================
+ Hits        19611    19684      +73     
- Misses        869      948      +79     
- Partials      109      253     +144

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the 12848-upload-static-images-to-be-used-by-the-image-component branch 3 times, most recently from 077820c to fe8f3b4 Compare August 13, 2024 13:14
@standeren standeren force-pushed the 12848-upload-static-images-to-be-used-by-the-image-component branch 2 times, most recently from 67e1251 to 05c18c8 Compare August 14, 2024 06:44
TomasEng
TomasEng reviewed Aug 14, 2024
View reviewed changes
Copy link
Contributor

@TomasEng TomasEng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har lagt igjen noen kommentarer på ting jeg har lagt merke til. Hovedpunkter:

  • Ikke vær redd for å dele opp ting i bittesmå biter - hovedregelen er at en funksjon skal gjøre én ting. Hvis du har mer enn to indenteringsnivåer, kan det være et hint om at det er lurt å dele opp.
  • Prøv å skille databehandlingskode (ikke-React) fra presentasjonskode (React), og lag egne enhetstester for databehandlingsnivået.
  • Unngå, hvis mulig, å kaste feilmeldinger som en del av det tiltenkte scenariet.

Ellers vil jeg på det sterkeste anbefale å begynne å skrive noen tester. Da vil du selv kunne oppdage deler av konden som kan struktureres på en bedre måte. Jeg ser for eksempel at du har kommentert at du ikke forstår hvorfor det er nødvendig med +1 et sted. Skill ut koden og lag en test, så får du svar!

frontend/packages/shared/src/utils/featureToggleUtils.ts Outdated Show resolved Hide resolved
...nents/config/editModal/EditImage/ConflictingImageSourceAlert/ConflictingImageSourceAlert.tsx Outdated Show resolved Hide resolved
frontend/packages/ux-editor/src/components/config/editModal/EditImage/EditImage.tsx Outdated Show resolved Hide resolved
frontend/packages/ux-editor/src/components/config/editModal/EditImage/EditImage.tsx Outdated Show resolved Hide resolved
frontend/packages/ux-editor/src/components/Properties/Text.tsx Outdated Show resolved Hide resolved
...src/components/config/editModal/EditImage/LocalImage/ImportImage/UploadImage/UploadImage.tsx Outdated Show resolved Hide resolved
...src/components/config/editModal/EditImage/LocalImage/ImportImage/UploadImage/UploadImage.tsx Show resolved Hide resolved
...components/config/editModal/EditImage/LocalImage/PreviewImageSummary/PreviewImageSummary.tsx Outdated Show resolved Hide resolved
.../config/editModal/EditImage/LocalImage/ImportImage/AddImageFromLibrary/ChooseFromLibrary.tsx Outdated Show resolved Hide resolved
frontend/packages/ux-editor/src/components/config/editModal/EditImage/EditImage.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. skip-releasenotes Issues that do not make sense to list in our release notes kind/dependencies Used for issues or pull requests that are dependency updates area/studio-root labels Aug 15, 2024
@standeren standeren force-pushed the 12848-upload-static-images-to-be-used-by-the-image-component branch 2 times, most recently from 45a311c to 1d6b7b2 Compare August 15, 2024 09:05
@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/dashboard Area: Related to the dashboard solution/platform Issues related to Altinn Platform solutions. quality/testing Tests that are missing, needs to be created or could be improved. area/pdf labels Aug 15, 2024
@standeren standeren force-pushed the 12848-upload-static-images-to-be-used-by-the-image-component branch 7 times, most recently from 0ae4a10 to 17d90b4 Compare August 19, 2024 13:58
standeren and others added 3 commits September 25, 2024 17:12
@standeren @TomasEng
Update frontend/packages/ux-editor/src/components/config/editModal/Ed…
18cca10 
…itImage/ExternalImage/ExternalImageValidationStatus.tsx

Co-authored-by: Tomas Engebretsen <tomas.engebretsen@digdir.no>
@standeren
Fix PR comments
b013be5
@standeren
Remove consolelog
65b73ba
@standeren standeren force-pushed the 12848-upload-static-images-to-be-used-by-the-image-component branch from 1eb5e13 to 88584af Compare September 25, 2024 15:12
@standeren standeren force-pushed the 12848-upload-static-images-to-be-used-by-the-image-component branch from 88584af to 07722d8 Compare September 25, 2024 15:19
@standeren standeren force-pushed the 12848-upload-static-images-to-be-used-by-the-image-component branch from 5339373 to 38ec507 Compare September 26, 2024 08:25
mlqn
mlqn approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK in dev! 🚀 It works as expected and meets all acceptance criteria, impressive work! 🤩

@standeren standeren force-pushed the 12848-upload-static-images-to-be-used-by-the-image-component branch from 8c53365 to c82ee58 Compare September 26, 2024 14:17
@standeren standeren force-pushed the 12848-upload-static-images-to-be-used-by-the-image-component branch from 21e3a4f to 3c3a106 Compare September 26, 2024 17:34
mlqn
mlqn approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@mlqn mlqn merged commit 710812b into main Sep 27, 2024
15 of 16 checks passed
@mlqn mlqn deleted the 12848-upload-static-images-to-be-used-by-the-image-component branch September 27, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@framitdavid framitdavid framitdavid left review comments

@mirkoSekulic mirkoSekulic mirkoSekulic approved these changes

@mlqn mlqn mlqn approved these changes

@TomasEng TomasEng TomasEng approved these changes

Assignees
No one assigned
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload static images to be used by the Image component
5 participants
@standeren @mirkoSekulic @mlqn @TomasEng @framitdavid