Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UtcNow instead of Now for DateTime and DateTimeOffset objects #339

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

CelineTrammi
Copy link
Contributor

@CelineTrammi CelineTrammi commented Oct 11, 2024

Use UtcNow and not Now for DateTime objects

Description

All DateTime objects using .Now, instead uses UtcNow at the moment. DateTime has also been replaced with DateTimeOffset, where it is applicable.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@CelineTrammi CelineTrammi marked this pull request as ready for review October 11, 2024 14:01
@CelineTrammi CelineTrammi marked this pull request as draft October 11, 2024 14:02
@CelineTrammi CelineTrammi marked this pull request as ready for review October 14, 2024 07:30
@CelineTrammi CelineTrammi merged commit 6fb0ceb into main Oct 14, 2024
5 checks passed
@CelineTrammi CelineTrammi deleted the fix/use-utcNow branch October 14, 2024 10:00
@CelineTrammi CelineTrammi added the kind/enhancement Improving existing feature label Oct 14, 2024
@CelineTrammi CelineTrammi changed the title Fix/use utc now Use UtcNow instead of Now for DateTime and DateTimeOffset objects Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improving existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants