Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ResourceAccessLevel to match authorization policy given #327

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

CelineTrammi
Copy link
Contributor

@CelineTrammi CelineTrammi commented Oct 8, 2024

Change ResourceAccessLevels from Send->Write and Open->Read. See is also removed.

Description

As mentionend in the related issue, the terms "Read" and "Write" are more commonly used across different platforms. To make it easier for the user, we are swithing the ResourceAccessLevels to align with these terms, that are also used for authentication policies.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@CelineTrammi CelineTrammi marked this pull request as ready for review October 9, 2024 07:57
Copy link
Collaborator

@Ceredron Ceredron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll update the dagl-correspondence resource to include the write action.

@Ceredron
Copy link
Collaborator

Ceredron commented Oct 9, 2024

This page needs to be updated: https://docs.altinn.studio/correspondence/getting-started/service-owner/

@CelineTrammi CelineTrammi merged commit 0b75954 into main Oct 9, 2024
7 checks passed
@CelineTrammi CelineTrammi deleted the fix/resource-access-level-read-write branch October 9, 2024 11:20
@CelineTrammi CelineTrammi added the kind/chore changes that do not relate to a fix or feature and don't modify src or test files label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore changes that do not relate to a fix or feature and don't modify src or test files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants