Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: validate DueDate and AllowSystemDelete for InitializeCorrespondence #243

Merged
merged 8 commits into from
Aug 30, 2024
Merged

Feat: validate DueDate and AllowSystemDelete for InitializeCorrespondence #243

merged 8 commits into from
Aug 30, 2024

Conversation

CelineTrammi
Copy link
Contributor

@CelineTrammi CelineTrammi commented Aug 29, 2024 •
edited
Loading

Lagt inn validering av DueDateTime og AllowSystemDeleteAfter, slik at verken av dem kan bli satt tidligere enn dagens dato eller VisibleFrom

Description

Det ble 5 forskjellige sjekker og feilmeldinger. Disse kan merges til noe InvalidDueDate eller liknende dersom det er ønsket.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@CelineTrammi CelineTrammi linked an issue Aug 29, 2024 that may be closed by this pull request
Valideringskrav for å opprette correspondence #232
Closed
@CelineTrammi CelineTrammi marked this pull request as ready for review August 30, 2024 06:26
Ceredron
Ceredron approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@Ceredron Ceredron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@CelineTrammi CelineTrammi merged commit c40d827 into main Aug 30, 2024
4 checks passed
@CelineTrammi CelineTrammi deleted the feat/initcorrespondence-duedate-allowsystemdelete-validation branch August 30, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ceredron Ceredron Ceredron approved these changes

Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Valideringskrav for å opprette correspondence
2 participants
@CelineTrammi @Ceredron