Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove data location url in responses #231

Merged
merged 17 commits into from
Aug 29, 2024

Conversation

CelineTrammi
Copy link
Contributor

@CelineTrammi CelineTrammi commented Aug 27, 2024

Fjern datalocationUrl fra respons slik at det ikke eksponeres for brukeren

Description

Fjernet fra de som var direkte i Response objekter og fleste som var i External mappers.

Datalocationurl er fjernet fra:

  • GetAttachmentDetailsResponse
  • GetAttachmentOverviewResponse
  • AttachmentDetailsMapper
  • AttachmentOverviewMapper
  • CorrespondenceAttachmentMapper
  • AttachmentOverviewExt
  • InitializeCorrespondenceAttachmentExt

Den siste er kanskje mest interessant siden dette gjør at CorrespondenceAttachmentEntity ikke får med seg DataLocationUrl, men den er fremdeles DataLocationUrl for AttachmentEntity i databasen.

I tillegg til disse endringene, er det laget en klasse BaseAttachmentExt som InitializeAttachmentExt og InitializeCorrespoondenceAttachmentExt arver fra.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@CelineTrammi CelineTrammi linked an issue Aug 27, 2024 that may be closed by this pull request
@CelineTrammi CelineTrammi marked this pull request as ready for review August 29, 2024 09:21
Copy link
Collaborator

@Ceredron Ceredron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
We should update swagger in https://github.com/Altinn/altinn-studio-docs/tree/master/static/swagger with removed field.

@Andreass2 Can we remove DataLocationType from external API models too? (Can keep it in db).

@Andreass2
Copy link
Collaborator

LGTM! We should update swagger in https://github.com/Altinn/altinn-studio-docs/tree/master/static/swagger with removed field.

@Andreass2 Can we remove DataLocationType from external API models too? (Can keep it in db).

yeah, I think so. If you would use an externalStorage. You should use the ExternalReferences values. So I Actually think it can be removed everywhere(Except DB of course). Good catch, missed it when I created the issue.

@CelineTrammi CelineTrammi merged commit 93f9a80 into main Aug 29, 2024
4 checks passed
@CelineTrammi CelineTrammi deleted the fix/removeDataLocationUrlInResponses branch August 29, 2024 14:26
@CelineTrammi CelineTrammi added kind/enhancement Improving existing feature kind/chore changes that do not relate to a fix or feature and don't modify src or test files labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore changes that do not relate to a fix or feature and don't modify src or test files kind/enhancement Improving existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataLocationUrl skal ikke være en verdi som brukere kan se
3 participants