-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/remove data location url in responses #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We should update swagger in https://github.com/Altinn/altinn-studio-docs/tree/master/static/swagger with removed field.
@Andreass2 Can we remove DataLocationType from external API models too? (Can keep it in db).
yeah, I think so. If you would use an externalStorage. You should use the ExternalReferences values. So I Actually think it can be removed everywhere(Except DB of course). Good catch, missed it when I created the issue. |
Fjern datalocationUrl fra respons slik at det ikke eksponeres for brukeren
Description
Fjernet fra de som var direkte i Response objekter og fleste som var i External mappers.
Datalocationurl er fjernet fra:
Den siste er kanskje mest interessant siden dette gjør at
CorrespondenceAttachmentEntity
ikke får med seg DataLocationUrl, men den er fremdeles DataLocationUrl for AttachmentEntity i databasen.I tillegg til disse endringene, er det laget en klasse
BaseAttachmentExt
somInitializeAttachmentExt
ogInitializeCorrespoondenceAttachmentExt
arver fra.Related Issue(s)
Verification
Documentation