Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadyForPublish should be set after virus scan #212

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

Ceredron
Copy link
Collaborator

@Ceredron Ceredron commented Aug 19, 2024

Description

ReadyForPublish should be set after virus scan when running in Azure. Only locally should it be set after upload. Correspondences associated with malware attachments should also fail.

I also did some re-factoring by injecting the helper classes that contain shared application logic.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

…chment being ready for publish after the virus scan when running remotely.
…dler by also injecting the helpers through DI and having their dependencies resolved automatically.
Copy link
Collaborator

@Andreass2 Andreass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup!

@Ceredron Ceredron merged commit c1384a5 into main Aug 19, 2024
4 checks passed
@Ceredron Ceredron deleted the fix/readyforpublish-after-virusscan branch August 19, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants