Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zookeeper advanced setup with empty dir #993

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

luluz66
Copy link
Contributor

@luluz66 luluz66 commented Aug 18, 2022

Thanks for taking the time to contribute to clickhouse-operator!

Please, read carefully instructions on how to make a Pull Request.

This will help a lot for maintainers to adopt your Pull Request.

Important items to consider before making a Pull Request

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

--

1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

1. create directories /var/lib/zookeeper/data before it's used
2. remove 04-storageclass-zookeeper.yaml from YAML_FILES_LIST
       since it's not used, and will cause "error: no objects passed to
       apply" when running `zookeeper-volume-emptyDir-create.sh`

       Signed-off-by: Lulu Zhang <lulu@buildbuddy.io>
@Slach Slach merged commit ec104f6 into Altinity:0.20.0 Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants