Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Task Failure Fixes #75

Merged
merged 3 commits into from
Jan 16, 2025
Merged

CI Task Failure Fixes #75

merged 3 commits into from
Jan 16, 2025

Conversation

ChristianBorst
Copy link
Collaborator

@ChristianBorst ChristianBorst commented Jan 14, 2025

The CI failures leading to the release of v1.5.1 (Tethys Upgrade) were not observed locally and so they were temporarily ignored. This PR fixes those failures:

  • Go lint errors are resolved
  • A Go test was failing because of an error made while fixing test lints (see the change to ibcutils)
  • Rust audits failed but those only affect the test env - these have been resolved

@ChristianBorst ChristianBorst force-pushed the c/go-lints branch 2 times, most recently from 65e53f3 to 07d586d Compare January 14, 2025 18:46
@ChristianBorst ChristianBorst changed the title Go lint fixes Go lint + test fixes Jan 16, 2025
@ChristianBorst ChristianBorst changed the title Go lint + test fixes CI Task Failure Fixes Jan 16, 2025
@jkilpatr jkilpatr self-requested a review January 16, 2025 21:54
@jkilpatr jkilpatr merged commit b63e1b3 into main Jan 16, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants