Check in compiled contracts required for build #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unfortunately required for a reliable build experience. We've done this before, gone back on this decision due to the lack of transparency when checking in any binary output and then come back here out of pragmatisim when it comes to the difficulty of actually executing builds and ensuring those making their own builds don't have issues. This contract bytecode is fully reproducbile by anyone else building it, and explorer verification should also cross verify.
jkilpatr
force-pushed
the
jkilpatr/check-in-contracts
branch
from
8d043ec to
b8eda96
Compare
ChristianBorst
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unfortunately required for a reliable build experience. We've done this before, gone back on this decision due to the lack of transparency when checking in any binary output and then come back here out of pragmatisim when it comes to the difficulty of actually executing builds and ensuring those making their own builds don't have issues.
This contract bytecode is fully reproducbile by anyone else building it, and explorer verification should also cross verify.