Tethys upgrade #68
Closed
Tethys upgrade #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianBorst
force-pushed
the
c/sdk-46-upgrade
branch
4 times, most recently
from
561c7f4 to
f9e73d7
Compare
ChristianBorst
force-pushed
the
c/sdk-46-upgrade
branch
8 times, most recently
from
2804ff9 to
3c90f71
Compare
This patch modifies the integration tests to run natively, as in without a container wrapping them, in github actions CI.
ChristianBorst
force-pushed
the
c/sdk-46-upgrade
branch
from
063c792 to
14583fc
Compare
ChristianBorst
force-pushed
the
c/sdk-46-upgrade
branch
4 times, most recently
from
af9b9ad to
0ae35df
Compare
The binary and go testing depends on the solidity folder contents because we embed contracts for use by the x/erc20 module. To fix the go CI tasks they must all install node.js and compile the solidity folder before formatting the output for use by the go files in contracts. After this the build, lint, and test tasks can all run. Because they are no longer dependent on the build step, test and lint are now completely parallel with build.
ChristianBorst
force-pushed
the
c/sdk-46-upgrade
branch
3 times, most recently
from
89a69e1 to
739f992
Compare
ChristianBorst
force-pushed
the
c/sdk-46-upgrade
branch
from
739f992 to
1dd932e
Compare
This test required no error for calling an endpoint that didn't exist. Behavior wise this wasn't ever correct but previously the failure occured at a different location in the call. Now it correctly occurs when we try to call a method that obviously doesn't exist. Contriburing to this is that calling "" is implicitly the constructor. So the error was different than it normally would be for a unknown method.
Since the docker test and the ci test run on different flows now we need to call this specifically in the ci flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features: