Add onboarding module for automatic ERC20 wrapping #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianBorst
changed the title
ChristianBorst
force-pushed
the
christianborst/onboarding
branch
from
07c9bac to
0bd8a13
Compare
ChristianBorst
force-pushed
the
christianborst/onboarding
branch
2 times, most recently
from
0511fd7 to
dc99cc5
Compare
This was referenced Apr 19, 2024
jkilpatr
requested changes
Apr 20, 2024
There was a problem hiding this comment.
How much of this IBC testsuite is running? I think from our discussion that we don't end up running this and can maybe carve several thousand lines out of this PR by not importing code we don't use.
But if it's being used by some test that does run successfully I have qualms about keeping it around.
jkilpatr
approved these changes
Apr 22, 2024
The onboarding module automatically wraps ERC20 coins on transfer into Althea-L1 for whitelisted channels so that registered tokens that land on chain are automatically usable within the EVM. Any coins which do not have an ERC20 representation or come from a non-whitelisted channel will be treated like an ordinary IBC Transfer.
These tests are largely a copy of the Canto onboarding tests but without any of the swap logic and many minor alterations to make them work with the Althea-L1 configuration. Notably if the denom is not "aalthea" the tests fail, and some of the setup tasks needed to be altered as well.
ChristianBorst
force-pushed
the
christianborst/onboarding
branch
from
8356a78 to
eee6749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.