Ember 2.10 Compatibility #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merged per f2f review/ tom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre 2.10,
ember-get-componentrelied on the existence of thechildViewsproperty on a given component. The addon then traversed that parent component child views to find the component instance we're probably interested in testing.In 2.10,
childViewsis not reliable at all and was advised by rwjblue that it should not be used. We ended up using the view registry which is also private and will likely not exist in the future, but this is at least not a regression and keeps our tests running.Context:
emberjs/ember.js#11244