Unable to sort and filter JSON fields

[dalenhughes]

I'm looking to expand the functionality to handle sorting and filtering for JSON field data.

Would like this to work using PostgresSQL database's built-in jsonb object which allows indexing. Would involve augmenting one of the models to include nested JSON. Here are the options I came up with:

1. Treat the JSON field like a text field
2. Convert the tests to Postgres
3. Test two configurations, one with sqlite, one with postgres
4. We could maintain a fork of the project

https://docs.djangoproject.com/en/2.1/ref/contrib/postgres/fields/

[dalenhughes]

thoughts? @ryochiji

[joshvillbrandt]

Hi @AltSchool team, I'm working with @dalenhughes on this feature. @dalenhughes has this up and running on a branch and we've opened a pull request. The branch is able to do deep filtering and sorting on jsonb field types.

As @dalenhughes mentioned above, the primary outstanding element with this change is figuring out how to test this feature since it depends on JSON field types. JSON fields, however, aren't supported with sqlite which is the database implementation used in the dynamic-rest types. Our best ideas for testing so far are:

1. Utilize an extension (via requirements.test.txt only) to add a json field type to sqlite; this needs more research as such a package might not exist
2. Convert the tests to postgres

Do you guys have a preference of approach? Can you think of an easier way to test this feature? Is this a feature you'd be interested in supporting in dynamic-rest in the first place? Please let us know.

(PS: Thanks again for your continued support of this repo!!)

[joshvillbrandt]

Ping @ryochiji, @atzannes, @DeviateFish - would someone mind reviewing our request? We'd like to get this merged so that we aren't maintaining a separate fork.

Thanks for your time and support!

[atzannes]

Hey @joshvillbrandt and @dalenhughes, thank you for your interest in the project. Unfortunately, I'm not very knowledgeable and will defer to Ryo. I contacted him and it's on his radar to reply to you as soon as he finds some time. Apologies for the slow turn-around.

[joshvillbrandt]

Awesome. Thanks for the update! :)

[mattmendivil]

@aleontiev @suavesav and @chdastolfo I have a draft PR up for fixing this issue- I'm having some issues running tests locally so I'd like to utilize the workflows that are automatically run on PRs.

Could one of you approve running the workflow on this PR?

Thanks!