Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in cmake file, AABB default values #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pkomon-tgm
Copy link

  • fix some typos in the CMake function alp_add_git_repository
  • change default values for AABB to more reasonable ones
    • set std::numeric_limits<T>::max() as default for geometry::Aabb<N, T>.max
    • set std::numeric_limits<T>::min() as default for geometry::Aabb<N, T>.min
    • previously 0 was used, which lead to some counter-intuitive behavior when expanding a default-initialized Aabb by a single point; expected: covers only new point; actual: covers 0 and new point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant