Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/aws_iot_ca_certificate #1

Closed
wants to merge 1 commit into from

Conversation

AlmogCohen
Copy link
Owner

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes Pull Request hashicorp#15098 (here)[https://github.com/hashicorp/pull/15098]

I saw that the other PR isn't accepted so I've decided to fix it and get it merged. Unfortunately I didn't have enough time to get the acceptance tests working for the resource. To break the work down, I've added only the data object for the registration code and fixed the relevant accaptance tests.

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSIotRegistrationCodeDataSource'

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIotRegistrationCodeDataSource -timeout 180m
=== RUN   TestAccAWSIotRegistrationCodeDataSource_basic
=== PAUSE TestAccAWSIotRegistrationCodeDataSource_basic
=== CONT  TestAccAWSIotRegistrationCodeDataSource_basic

--- PASS: TestAccAWSIotRegistrationCodeDataSource_basic (180.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	182.027s

@AlmogCohen AlmogCohen marked this pull request as ready for review October 11, 2021 12:45
@AlmogCohen AlmogCohen closed this Oct 11, 2021
@AlmogCohen AlmogCohen deleted the feature/aws_iot_ca_certificate branch October 11, 2021 12:45
@AlmogCohen AlmogCohen restored the feature/aws_iot_ca_certificate branch October 11, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant