Remove hostname from metrics key #18121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maobaolong
approved these changes
Sep 11, 2023
beinan
force-pushed
the
remove_hostname_from_metrics_key
branch
from
7ae1693 to
be77b18
Compare
|
alluxio-bot, merge this please. |
|
merge failed: |
|
alluxio-bot, merge this please. |
|
alluxio-bot, cherry-pick this to master-2.x please |
|
Auto cherry-pick unsuccessful Failed to setup local git for auto cherry-pick 6165c0d cannot be auto cherry-picked to branch master-2.x. Please cherry-pick this manually. |
alluxio-bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
### What changes are proposed in this pull request? cherry-pick #18121 ### Why are the changes needed? Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, describe the bug. ### Does this PR introduce any user facing changes? Please list the user-facing changes introduced by your change, including 1. change in user-facing APIs 2. addition or removal of property keys 3. webui pr-link: #18626 change-id: cid-31f20b47904c5f32c9c11c08f3155cfcdcbf4e16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Remove hostname from metrics key
Why are the changes needed?
For easy aggregation on prometheus and grafana side
Does this PR introduce any user facing changes?
Add a flag to disable this for compatibility