Skip to content

Commit

Permalink
Replace Source Code Pro with Anonymous Pro font
Browse files Browse the repository at this point in the history
The reason I'm proposing replacing SCP with AP is because there is a
bug in firefox and/or MacOS which causes this font to render
incorrectly.

See:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1534503
- https://bugzilla.mozilla.org/show_bug.cgi?id=1520157

Anonymous Pro is a bit more lightweight and has at least been recently
updated by its maintainers (1.44.0 was 3 months ago). SCP is definitely
more ubiquitous and well-maintained but I would rather have a font that
works everywhere. As an added bonus, this font is *much* more
lightweight than SCP.

Additionally, it seems the maintainers of the project have no desire to
address or look into what triggered the regression:
adobe-fonts/source-code-pro#217

pr-link: #10826
change-id: cid-b0c413b42cf8cffd0913fbe581bde24d576efa89
  • Loading branch information
ZacBlanco committed Feb 1, 2020
1 parent 77dc898 commit 5b001c9
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion webui/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"@fortawesome/free-regular-svg-icons": "5.7.2",
"@fortawesome/free-solid-svg-icons": "5.7.2",
"@fortawesome/react-fontawesome": "0.1.4",
"@openfonts/anonymous-pro_all": "^1.44.0",
"bootstrap": "4.3.1",
"bootswatch": "4.3.1",
"jquery": "1.9.1",
Expand All @@ -17,7 +18,6 @@
"react-router-dom": "4.3.1",
"react-scripts": "2.1.5",
"reactstrap": "7.1.0",
"source-code-pro": "^2.30.1",
"source-sans-pro": "^2.45.0",
"source-serif-pro": "^2.10.0"
},
Expand Down
2 changes: 1 addition & 1 deletion webui/common/src/constants/scss/_themeVariables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
$web-font-path: ''; // override default font download path
$font-family-sans-serif: 'Source Sans Pro', sans-serif !default;
$font-family-serif: 'Source Serif Pro', serif !default;
$font-family-monospace: 'Source Code Pro', monospace !default;
$font-family-monospace: 'Anonymous Pro', monospace !default;
$font-family-base: $font-family-sans-serif !default;
2 changes: 1 addition & 1 deletion webui/common/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import App from './App';

import 'source-sans-pro/source-sans-pro.css';
import 'source-serif-pro/source-serif-pro.css';
import 'source-code-pro/source-code-pro.css';
import '@openfonts/anonymous-pro_all';

import './index.css';

Expand Down
2 changes: 1 addition & 1 deletion webui/master/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"@fortawesome/free-regular-svg-icons": "5.7.2",
"@fortawesome/free-solid-svg-icons": "5.7.2",
"@fortawesome/react-fontawesome": "0.1.4",
"@openfonts/anonymous-pro_all": "^1.44.0",
"@nivo/line": "^0.52.1",
"axios": "0.18.0",
"babel-polyfill": "6.26.0",
Expand All @@ -25,7 +26,6 @@
"reactstrap": "7.1.0",
"redux": "4.0.1",
"redux-saga": "1.0.1",
"source-code-pro": "^2.30.1",
"source-sans-pro": "^2.45.0",
"source-serif-pro": "^2.10.0",
"typesafe-actions": "3.1.0"
Expand Down
2 changes: 1 addition & 1 deletion webui/master/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { initialState } from './store';

import 'source-sans-pro/source-sans-pro.css';
import 'source-serif-pro/source-serif-pro.css';
import 'source-code-pro/source-code-pro.css';
import '@openfonts/anonymous-pro_all';

import './index.css';
import { IAppProps } from './containers/App/App';
Expand Down
10 changes: 5 additions & 5 deletions webui/npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion webui/worker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"@fortawesome/free-regular-svg-icons": "5.7.2",
"@fortawesome/free-solid-svg-icons": "5.7.2",
"@fortawesome/react-fontawesome": "0.1.4",
"@openfonts/anonymous-pro_all": "^1.44.0",
"axios": "0.18.0",
"babel-polyfill": "6.26.0",
"bootstrap": "4.3.1",
Expand All @@ -24,7 +25,6 @@
"reactstrap": "7.1.0",
"redux": "4.0.1",
"redux-saga": "1.0.1",
"source-code-pro": "^2.30.1",
"source-sans-pro": "^2.45.0",
"source-serif-pro": "^2.10.0",
"typesafe-actions": "3.1.0"
Expand Down
2 changes: 1 addition & 1 deletion webui/worker/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { initialState } from './store';

import 'source-sans-pro/source-sans-pro.css';
import 'source-serif-pro/source-serif-pro.css';
import 'source-code-pro/source-code-pro.css';
import '@openfonts/anonymous-pro_all';

import './index.css';
import { IAppProps } from './containers/App/App';
Expand Down

0 comments on commit 5b001c9

Please sign in to comment.