Loading too many thumbnails in Local image viewer

[morzineIT]

When I use the local Admin panel to view last night's images,
It loads the first page with thumbnails of all the photos ok.
Then when I click on one image, it tries loading 3000 thumbnails at the bottom of the page with forward / back / play etc.
The Pi hangs for a few minutes while it does this.

I think it should limit the loading to X number of images either side of the selected one.

I'm sure the answer from some people would be " don't have 3000 images" !

(I'll try to stop raising issues - sorry - it must me my old IT development past coming back to haunt me !)

[EricClaeys]

@morzineIT Please don't stop raising Issues. We can't fix bugs if we don't know about them.
It does this by design so it's easy to skip to a different image, but I agree on the "Images" page this doesn't make sense since most people (I'd guess) have at least 1000 images a day. For other pages like like Keograms, where there's only 1 per page, it probably makes sense.
I'll take a look at it - it may be a while since there's a long list of things we're working on.

[EricClaeys]

@morzineIT This was fixed a couple days ago. If there are less than 50 images it displays the tiny ones at the bottom, otherwise it doesn't. 50 was an arbitrary number - on my Pi 4 it displays 50 small ones very quickly. I probably could have increased 50 but didn't feel like testing with higher numbers. Besides, a lot of people have slower machines than the Pi 4.
The file that fixes this is allsky-portal/includes/images.php.

[kopi23]

hi eric, could it be that this use case doesn't just produce load on the pi but also on the client?
when clicking on a thumbnail in the image viewer, the cpu of my desktop pc goes way up until the image is displayed.
on my old desktop it takes about 40 seconds, on my phone about 55 seconds and on my new desktop about 5 seconds.
each tested with the same image folder (day) with about 1900 images on a pi4 with 8gb of ram.
maybe you could make that amount of '50 images' configurable? maybe even add a switch or boolean to disable the buffering feature as well? i usually just want to look at one specific image like an iss transit or yesterday i saw a big black spot in the time lapse and then saw in the single image that a fly sat on the lens.
thank you, kopi

[EricClaeys]

@kopi23 The next major release of Allsky will have a much improved "Images" page. 1000 thumbnails will load in about 1 second. I'm not sure what type of PC @Alex-developer had, but it's likely fast.

[morzineIT]

That's awesome - thankyou It was really bad ! I had thousands of images and it totally crashed my Pi. Thanks again - I'll install and test now..

…

On Thu, 21 Oct 2021 at 06:13, EricClaeys ***@***.***> wrote: @morzineIT <https://github.com/morzineIT> This was fixed a couple days ago. If there are less than 50 images it displays the tiny ones at the bottom, otherwise it doesn't. 50 was an arbitrary number - on my Pi 4 it displays 50 small ones very quickly. I probably could have increased 50 but didn't feel like testing with higher numbers. Besides, a lot of people have slower machines than the Pi 4. The file that fixes this is allsky-portal/includes/images.php. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#687 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7HUYRWESIDOS72XAH33W3UH6HNLANCNFSM5GNEM44Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[EricClaeys]

@morzineIT, let me know how it goes. If it works, would you please change the Label of this Discussion to "Fixed"? You can do that near the top-right of the page. Thanks.