Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling updates to different assets #33

Open
dbirman opened this issue Dec 13, 2024 · 2 comments
Open

Handling updates to different assets #33

dbirman opened this issue Dec 13, 2024 · 2 comments
Assignees
Labels
feature New feature
Milestone

Comments

@dbirman
Copy link
Member

dbirman commented Dec 13, 2024

User story

As a user I might modify the state of a QCMetric in a different asset than the one that I loaded in the portal. Should the portal push that update back to the original asset?

I think we do have to sync at upload time, otherwise if we rely on the indexer to sync assets we run the risk of having someone update two different assets and then we need to do merges (in practice the merge is trivial since everything is timestamped, but form a user's perspective it might not be obvious what happened).

[tbd]

@saskiad
Copy link

saskiad commented Dec 13, 2024

Can we make some specific examples?

e.g. evaluate raw asset and apply evaluation to specific or all of its derived assets. This one is obvious to me. The opposite is not.
Would this always be related assets - e.g. same subject, raw/derived - or are there other examples you have in mind

@dbirman
Copy link
Member Author

dbirman commented Dec 13, 2024

Can we make some specific examples?

e.g. evaluate raw asset and apply evaluation to specific or all of its derived assets. This one is obvious to me. The opposite is not. Would this always be related assets - e.g. same subject, raw/derived - or are there other examples you have in mind

Let's say we have three assets: raw, derived_0, and derived_1, each of which has one QCEvaluation attached to it, qc_raw, qc_derived_0, and qc_derived_1. If we create these assets in order we end up with:

  • raw: quality_control.json includes qc_raw
  • derived_0: quality_control.json includes qc_raw and qc_derived_0
  • derived_1: quality_control.json includes qc_raw, qc_derived_0, and qc_derived_1

The issue like you said goes in two directions. If I open the raw asset in the QC portal and make a change, this should get propagated down to the derived_0 and derived_1 assets. But the same is true in the other direction, if I open the derived_0 asset and modify the qc_raw evaluation then I need that to propagate back up to the raw asset and to the derived_1 downstream asset.

It's only ever in the same asset chain.

@dbirman dbirman added the feature New feature label Jan 15, 2025
@dbirman dbirman added this to the v1 milestone Jan 15, 2025
@dbirman dbirman self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants