add history dependency #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madeinfree
reviewed
Nov 15, 2016
| @@ -64,6 +64,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "classnames": "^2.1.2", | |||
| "history": "^1.17.0", | |||
There was a problem hiding this comment.
I think it may not necessary for react-bootstrap-table, but example use it, maybe we can move it into devDependencies ?
There was a problem hiding this comment.
I agree. BTW, This issue has been fixed on the branch of v3.0.0-dev.
There was a problem hiding this comment.
My bad @madeinfree I just pushed a commit with the requested changes.
@AllenFang Thank you for your hard work! Really looking forward to stable version of 3.0!
AllenFang
approved these changes
Nov 15, 2016
|
@bencooling, thanks your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #797