Data get sorted locally even with remote sorting

[jfremy]

react-bootstrap-table/src/BootstrapTable.js

Line 281 in 97171e1

data = this.store.sort().get();

When using a remote data source and remote sorting, react bootstrap table still sorts the data locally even though it should not.
I think the bug is located in BootstrapTable.js line 281 (in componentWillReceiveProps) and should probably be something like this:

if (!this.allowRemote(Const.REMOTE_SORT)){
  data = this.store.sort().get();
}
newState.data = data;

I'm not completely familiar with that part of the code so the fix proposal might not be the right one.

I think the previous condition block (the if (this.store.isOnFilter) { ... }) probably need the same kind of logic checking for support of Const.REMOTE_FILTER.

[AllenFang]

@jfremy I'll check it soon

[AllenFang]

However, in the block of if (this.store.isOnFilter) { ... }, it will call the handleXXX function, in those function, we already check is remote or not.

[HomelessSamurai]

I've also been stuck on this issue for the past two days and only after reading this post have finally fixed it.
The proposed solution by @jfremy has fixed the bug for me and now local sorting doesn't occur.
Can you please add this in and release an update

[AllenFang]

sure, this will be fixed on next release.

[HomelessSamurai]

Thank you. When will the next release occur?

[meet-asite]

We are also stuck due to this bug and waiting for the next release.

[AllenFang]

11/10, I can promise it, sorry about this mistake.

[AllenFang]

Released on v4.1.2. Let me know if the problem still remain.

[meet-asite]

@AllenFang I have updated to v4.1.2. Now I am getting blank table with message: "There is no data to display" even though I have got data from the server. Could you please check?

[jfremy]

Yes, I'm seeing the same.
@AllenFang the newState.data = data; part should not be inside the if (!this.allowRemote(Const.REMOTE_SORT)){ ... } block.
It must be run with or without remote sort.

[harryxu]

@meet-asite @AllenFang I am getting blank table too, after updated to v4.1.2 just now. 😅

[AllenFang]

I'm shame on this mistake, fixed it again and released on v4.1.3. :(

[prajapati-parth]

@AllenFang To avoid such situations in future for react-bootstrap-table2, do you think we can have e2e tests that runs after every merge to master?

[AllenFang]

Something we can done for unit test, e2e test I will consider, but if we have more stronger unit tests in react-bootstrap-table2, this bug will be easy to tested. So in current development for react-bootstrap-table2, I claim that we need to write tests for more detail in particular.

[dawnmist]

I think something went wrong with the 4.1.3 release - looking at the compiled code in lib in the released package, it doesn't contain the fix you added and on the page the table still shows only the "no data" message in the table.

[meet-asite]

I am still getting blank table with V4.1.3

[AllenFang]

try again on v4.1.4 and let me know if the problem still remain, thanks

[dawnmist]

Tables are displaying data properly now. :)

[meet-asite]

Thank you @AllenFang remote sorting is working properly now.

[AllenFang]

Thanks you guys. it's sorry that I make some mistake when released. :P