Skip to content

Commit

Permalink
Search bar too small on small screens (eg. iphone4/5)
Browse files Browse the repository at this point in the history
On an iPhone sized screen, the search box becomes one and a half characters wide. It also overlaps on top of some buttons if they are enabled.
This further doesn't make sense if none of the three buttons in the first column (exportCSV, deleteBtn, insertBtn) are even enabled.

My change ensures the search field sits below the buttons and at a decent width for small screens.

The change which prompted this issue was [this one](8e43d26#diff-c2216bf93dd49b5ad9bf3f7422d40ffcR144).

By the way, I'm loving this library, it's fantastic! Awesome job everyone!
  • Loading branch information
deadbeef404 committed Jan 8, 2016
1 parent baa8b1a commit 674bf95
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/toolbar/ToolBar.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,13 @@ class ToolBar extends React.Component{
return(
<div className="row">
<div className="col-xs-9">
<div className="btn-group btn-group-sm" role="group">
<div className="col-xs-12 col-sm-6 col-md-6 col-lg-8" role="group">
{exportCSV}
{insertBtn}
{deleteBtn}
</div>
</div>
<div className="col-xs-3">
<div className="col-xs-12 col-sm-6 col-md-6 col-lg-4">
{searchTextInput}
</div>
<Notifier ref="notifier"></Notifier>
Expand Down

1 comment on commit 674bf95

@deadbeef404
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn, I messed that one up.. I'll fix it..

Please sign in to comment.