Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates heroicon / replaces it with rails-heroicon #52

Merged
merged 1 commit into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ gem "bootsnap", require: false

# Use Active Storage variants [https://guides.rubyonrails.org/active_storage_overview.html#transforming-images]
# gem "image_processing", "~> 1.2"
gem "heroicon", "~> 0.4.0"
gem "rails_heroicon", "~> 2.2.0"

group :development, :test do
# See https://guides.rubyonrails.org/debugging_rails_applications.html#debugging-with-the-debug-gem
Expand Down
7 changes: 4 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,6 @@ GEM
faraday-net_http (3.0.2)
globalid (1.2.1)
activesupport (>= 6.1)
heroicon (0.4.0)
rails (>= 5.2)
htmlbeautifier (1.4.2)
i18n (1.14.1)
concurrent-ruby (~> 1.0)
Expand Down Expand Up @@ -214,6 +212,9 @@ GEM
rails-html-sanitizer (1.6.0)
loofah (~> 2.21)
nokogiri (~> 1.14)
rails_heroicon (2.2.0)
actionview
railties
railties (7.1.2)
actionpack (= 7.1.2)
activesupport (= 7.1.2)
Expand Down Expand Up @@ -346,7 +347,6 @@ DEPENDENCIES
byebug
capybara
debug
heroicon (~> 0.4.0)
htmlbeautifier
importmap-rails
pg (~> 1.1)
Expand All @@ -355,6 +355,7 @@ DEPENDENCIES
puma (>= 5.0)
rails (~> 7.1.2)
rails-controller-testing
rails_heroicon (~> 2.2.0)
redis (>= 4.0.1)
rubocop-capybara
rubocop-minitest
Expand Down
5 changes: 0 additions & 5 deletions app/helpers/heroicon_helper.rb

This file was deleted.

2 changes: 1 addition & 1 deletion app/views/shared/_settings_modal.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<p>Settings</p>
</button>
<a href="/logout" class='flex space-x-2 p-2 hover:bg-black/80 mx-2 rounded text-white text-sm items-center'>
<%= heroicon "logout" , options: { class: 'h-5 w-5 text-gray-300' } %>
<%= heroicon "arrow-right-start-on-rectangle" , options: { class: 'h-5 w-5 text-gray-300' } %>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There now no icon called logout and there was some discussion about it all. Apparently people disagree with what looks like a logout arrow and what doesn't 😂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i intentionally added the old version since it had icons that looked similar to old chatgpt and yeah that icon is different. :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I was noting that as well. But the odd thing is that it does look like the community is backing the v2 a little stronger than v1 (keeping libraries more updated, etc). The creator of v2 also talks about it as if it's his new baby — it's the new "modern" icon library. So I did a pass in my branch to try and move everything to the v2 icons and I got it looking pretty nice so we can just stick with it now.

<p>Logout</p>
</a>
<%= render "shared/modal" %>
Expand Down
10 changes: 0 additions & 10 deletions config/initializers/heroicon.rb

This file was deleted.

Loading