adds minimally functional page for assistant instructions #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschacht
reviewed
Jan 10, 2024
robacarp
force-pushed
the
assistant_instructions
branch
2 times, most recently
from
43e4ec2 to
8770dd6
Compare
robacarp
commented
Jan 10, 2024
| @@ -19,6 +19,9 @@ | |||
| <%= content_for :head %> | |||
| </head> | |||
| <body> | |||
| <% if notice.present? %> | |||
| <p class="py-2 px-3 bg-green-50 mb-5 text-green-500 font-medium rounded-lg inline-block" id="notice"><%= notice %></p> | |||
| <% end %> | |||
There was a problem hiding this comment.
I moved this flash notice up to the layout because messages were getting swallowed. It looks terrible, but I'm vaguely aware that @krschacht is working on styles? I'm happy to spruce it up if needed.
Anyway, with the notices getting swallowed, I wasn't able to write a helper method #login_user for the system integration tests and know that the login succeeded.
I'm happy to leave this as-is (minimally working) or to finish the refactor and make the notifications work system wide.
There was a problem hiding this comment.
This seems like a fine place for now
robacarp
commented
Jan 10, 2024
| @@ -3,7 +3,7 @@ | |||
| <h2 class='text-3xl font-semibold text-black/90'>Welcome back</h2> | |||
| <%= form_with(url: login_path, method: :post, class: "flex flex-col space-y-4 w-80") do |f| %> | |||
| <%= f.email_field :email, id: "email", autofocus: true, placeholder: "Email address", class: "border border-gray-400 rounded text-black p-3"%> | |||
| <%= f.password_field :password, id: "email", autofocus: true, placeholder: "Password", class: "border border-gray-400 rounded text-black p-3"%> | |||
| <%= f.password_field :password, id: "password", autofocus: true, placeholder: "Password", class: "border border-gray-400 rounded text-black p-3"%> | |||
There was a problem hiding this comment.
Lil bug prevented me from writing the system login_user method.
robacarp
commented
Jan 10, 2024
| @@ -33,5 +33,3 @@ | |||
|
|
|||
| # Allow puma to be restarted by `bin/rails restart` command. | |||
| plugin :tmp_restart | |||
|
|
|||
| plugin :solid_queue | |||
robacarp
force-pushed
the
assistant_instructions
branch
from
8770dd6 to
938f2b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #37
fixes #48