Skip to content

Commit

Permalink
updates heroicon helper
Browse files Browse the repository at this point in the history
The gem "heroicon" hasn't been updated in 18mo, and the heroicon pack has dramatically changed since then.

Another gem "rails-heroicon" seems to share a lot of the code but is actually bundled with a railtie and has carried updates as recently as 2 weeks ago. The interface is identical from the views, but it comes with all the names for icons which match the current heroicon website.

I've removed the heroicon helper and initializer. Neither are required by rails-heroicon.
  • Loading branch information
rob committed Jan 11, 2024
1 parent 39572f4 commit e4a7d09
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 20 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ gem "bootsnap", require: false

# Use Active Storage variants [https://guides.rubyonrails.org/active_storage_overview.html#transforming-images]
# gem "image_processing", "~> 1.2"
gem "heroicon", "~> 0.4.0"
gem "rails_heroicon", "~> 2.2.0"

group :development, :test do
# See https://guides.rubyonrails.org/debugging_rails_applications.html#debugging-with-the-debug-gem
Expand Down
7 changes: 4 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,6 @@ GEM
faraday-net_http (3.0.2)
globalid (1.2.1)
activesupport (>= 6.1)
heroicon (0.4.0)
rails (>= 5.2)
htmlbeautifier (1.4.2)
i18n (1.14.1)
concurrent-ruby (~> 1.0)
Expand Down Expand Up @@ -214,6 +212,9 @@ GEM
rails-html-sanitizer (1.6.0)
loofah (~> 2.21)
nokogiri (~> 1.14)
rails_heroicon (2.2.0)
actionview
railties
railties (7.1.2)
actionpack (= 7.1.2)
activesupport (= 7.1.2)
Expand Down Expand Up @@ -346,7 +347,6 @@ DEPENDENCIES
byebug
capybara
debug
heroicon (~> 0.4.0)
htmlbeautifier
importmap-rails
pg (~> 1.1)
Expand All @@ -355,6 +355,7 @@ DEPENDENCIES
puma (>= 5.0)
rails (~> 7.1.2)
rails-controller-testing
rails_heroicon (~> 2.2.0)
redis (>= 4.0.1)
rubocop-capybara
rubocop-minitest
Expand Down
5 changes: 0 additions & 5 deletions app/helpers/heroicon_helper.rb

This file was deleted.

2 changes: 1 addition & 1 deletion app/views/shared/_settings_modal.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<p>Settings</p>
</button>
<a href="/logout" class='flex space-x-2 p-2 hover:bg-black/80 mx-2 rounded text-white text-sm items-center'>
<%= heroicon "logout" , options: { class: 'h-5 w-5 text-gray-300' } %>
<%= heroicon "arrow-right-start-on-rectangle" , options: { class: 'h-5 w-5 text-gray-300' } %>
<p>Logout</p>
</a>
<%= render "shared/modal" %>
Expand Down
10 changes: 0 additions & 10 deletions config/initializers/heroicon.rb

This file was deleted.

0 comments on commit e4a7d09

Please sign in to comment.