why check the players twice

All-Of-Us-Mods · Oct 6, 2024 · 6220ba4 · 6220ba4
1 parent 9c9d222
commit 6220ba4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/MiraAPI/Modifiers/ModifierManager.cs b/MiraAPI/Modifiers/ModifierManager.cs
@@ -87,14 +87,14 @@ internal static void AssignModifiers(List<PlayerControl> plrs)
             foreach (var modifier in PrioritiesToIdsMap[priority])
             {
                 var mod = Activator.CreateInstance(IdToTypeModifierMap[modifier]) as GameModifier;
+                var maxCount = plrs.Count(x => IsGameModifierValid(x, mod!, modifier));
 
-                if (!plrs.Exists(x => IsGameModifierValid(x, mod!, modifier)))
+                if (maxCount == 0)
                 {
                     Logger<MiraApiPlugin>.Warning("No players are valid for modifier: " + mod!.ModifierName);
                     continue;
                 }
 
-                var maxCount = plrs.Count(x => IsGameModifierValid(x, mod!, modifier));
                 var num = Math.Clamp(mod!.GetAmountPerGame(), 0, maxCount);
                 var chance = mod.GetAssignmentChance();