Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fixing next page param extraction for app installation repos reponse #5687

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

malhotra5
Copy link
Contributor

@malhotra5 malhotra5 commented Dec 19, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

Pagination was broken because the Link header, which contains information about the next_page was not being forwarded from the backend. This PR fixes this issue.


Link of any specific issues this addresses
#5683


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:39716a4-nikolaik   --name openhands-app-39716a4   docker.all-hands.dev/all-hands-ai/openhands:39716a4

@malhotra5 malhotra5 marked this pull request as draft December 19, 2024 01:18
@malhotra5 malhotra5 changed the title [Bug]: Repo list don't return next page results for app installation repos [Bug]: Fixing next page param extraction for app installation repos reponse Dec 19, 2024
@malhotra5 malhotra5 marked this pull request as ready for review December 19, 2024 03:12
@malhotra5 malhotra5 enabled auto-merge (squash) December 19, 2024 03:28
@malhotra5 malhotra5 merged commit 3db118f into main Dec 19, 2024
13 checks passed
@malhotra5 malhotra5 deleted the bug/repo-list branch December 19, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants