Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asyncio issues with security analyzer + enable security analyzer in cli #5356

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

mbalunovic
Copy link
Contributor

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR fixes the issues related to asyncio that have broken the security analyzer with small edits in the analyzer and agent controller. Additionally, the PR enables using the security analyzer in the CLI by reading the config from config.toml file and modifying the CLI to include confirmation mode. This should also make it easier to debug the security analyzer in the future.


Link of any specific issues this addresses

#5264

Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@xingyaoww xingyaoww requested a review from amanape December 2, 2024 16:46
Copy link
Member

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now, thanks a lot!

@amanape amanape merged commit 871c544 into All-Hands-AI:main Dec 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants