Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue where exit session intermittently does not return to splash #5291

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Nov 27, 2024

Fix for issue where exit session intermittently does not return to splash


Exiting the session triggers a change of the token from some value to null, which triggers a disconnect, which triggers a reconnect. With this change, we no longer disconnect when the token changes to null.

Testing

Since this is caused by a race condition, reproduction is intermittent. I've found a reliable way to reproduce the issue is to start a new session with a simple prompt, wait for the task to finish, refresh the page, and then click the "Exit Project" button. Before the fix, OpenHands would not return to the splash screen but instead start a new session.
image
image

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:fdddb5b-nikolaik   --name openhands-app-fdddb5b   docker.all-hands.dev/all-hands-ai/openhands:fdddb5b

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:22e459f-nikolaik   --name openhands-app-22e459f   docker.all-hands.dev/all-hands-ai/openhands:22e459f

@tofarr tofarr marked this pull request as ready for review November 27, 2024 00:20
@tofarr tofarr enabled auto-merge (squash) November 27, 2024 15:16
@tofarr tofarr merged commit c70d160 into main Nov 27, 2024
14 checks passed
@tofarr tofarr deleted the fix-intermittant-non-return-to-splash branch November 27, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants