Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple initial rate limiting implementation #4976

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Nov 13, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    CHANGELOG: put some liberal rate limiting in place

Give a summary of what the PR does, explaining any non-trivial design decisions

This is a foot in the door to rate limiting. More robust, per-route rate limiting will be easier with some refactoring


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:df4db0a-nikolaik   --name openhands-app-df4db0a   docker.all-hands.dev/all-hands-ai/openhands:df4db0a

@rbren rbren marked this pull request as ready for review November 13, 2024 18:02
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 - if needed, once we have the redis integrated we could think about that as an alternative to in memory

@rbren rbren merged commit 3c61a95 into main Nov 19, 2024
13 checks passed
@rbren rbren deleted the rb/rate-limiting-take-10 branch November 19, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants