Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALL-561] feat(frontend|backend): Display error messages in the chat #4509

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amanape
Copy link
Member

@amanape amanape commented Oct 22, 2024

End-user friendly description of the problem this fixes or functionality that this introduces
When something wrong occurred in the agent or backend, the frontend would be empty and hardly display any indicator to the user.

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions
Utilize send_error to send ErrorObservation's as well and modify the frontend to catch and display them. Some examples:

Exception caught by report_error
Screenshot 2024-10-22 at 11 09 17

Error sent directly by send_error or as API error response are toast

TODO

  • Errors from send_error should be toast
  • Otherwise, inline in chat interface
  • Ensure that inline chat messages are the inline-style after a reload (they may be converted to user messages)

Link of any specific issues this addresses

@amanape amanape self-assigned this Oct 22, 2024
@amanape amanape requested a review from tofarr October 22, 2024 18:08
@amanape amanape marked this pull request as draft October 22, 2024 19:31
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I would like to test some of the different error states in the morning.

@amanape amanape marked this pull request as ready for review October 23, 2024 06:50
@amanape amanape requested review from tofarr and rbren October 23, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants