fix default host #4413
Merged
fix default host #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanape
approved these changes
Oct 16, 2024
| svgr(), | ||
| ], | ||
| server: { | ||
| port: FE_PORT, |
There was a problem hiding this comment.
If it is the default port that you want to fix (from 5173 to 3000), all you need to set is server.port. I don't think we are utilizing anything proxy-related here (it is a dev-only setting)
There was a problem hiding this comment.
right exactly--in dev mode, the FE now makes requests to localhost:3001/api/... and the proxy passes them to localhost:3000/api/...
That's a bit more like prod, where both FE and BE are at the same address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
none needed
Give a summary of what the PR does, explaining any non-trivial design decisions
Currently the app is broken if you
docker runon a port other than 3000Link of any specific issues this addresses