refactor: move get_pairs from memory to shared utils #4411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enyst
approved these changes
Oct 15, 2024
|
Good call! I was doing some reading history from jsonl, and it didn't occur to me to use this one. This looks better, it's just a utility converting format. |
AlexCuadron
pushed a commit
to AlexCuadron/OpenHands
that referenced
this pull request
Oct 16, 2024
AlexCuadron
pushed a commit
to AlexCuadron/OpenHands
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
I am hoping to use get_pairs from other eval scripts in the editing PR (example here: https://github.com/All-Hands-AI/OpenHands/pull/3985/files#diff-da3a53dcb2ace4b1d1acc580c43958796162db335ef86d5e43f8d0e491ed50e0R7), so it will be helpful to refactor this function out into
events.utils.Link of any specific issues this addresses