Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolves HumanEval Inference by replacing task_id with instance_id #4364

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

Ethan0456
Copy link
Contributor

@Ethan0456 Ethan0456 commented Oct 14, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

This PR resolves an issue in the HumanEval benchmark's run_infer.py script where the code incorrectly references a column task_id that no longer exists. The correct column is instance_id. This fix ensures that the script runs without errors, making it compatible with the latest schema changes.

  • Include this change in the Release Notes.
    End-user friendly description for the Release Notes:
    "Fixes a column reference issue in run_infer.py where task_id was incorrectly used instead of instance_id."

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR refactors the Humaneval benchmark's run_infer.py script by replacing all occurrences of task_id with instance_id to align with the updated column naming convention. No major design changes were made, but the code now references the correct column to avoid attribute errors and ensure smooth execution of the Humaneval benchmark.


Link of any specific issues this addresses

This PR addresses issue #4363, where an AttributeError occurs because the column name change from task_id to instance_id was not consistently applied throughout the file, leading to the error.

@Ethan0456 Ethan0456 changed the title fix #4363: replace task_id with instance_id fix #4363: Resolves HumanEval Inference by replacing task_id with instance_id Oct 14, 2024
@Ethan0456 Ethan0456 changed the title fix #4363: Resolves HumanEval Inference by replacing task_id with instance_id fix: Resolves HumanEval Inference by replacing task_id with instance_id Oct 14, 2024
@enyst enyst requested a review from xingyaoww October 15, 2024 03:01
Copy link
Contributor

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the bug!

@enyst enyst enabled auto-merge (squash) October 15, 2024 15:11
@enyst enyst merged commit 173018e into All-Hands-AI:main Oct 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants