refactor: re-organize different runtime implementations into an impl folder #4346
+63
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingyaoww
requested review from
rbren and
neubig
and removed request for
rbren
1 task
neubig
reviewed
Oct 23, 2024
neubig
reviewed
Oct 23, 2024
neubig
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
Re-organize different runtime implementations into an impl folder, otherwise code/folder looks a bit messy.
Feel free to suggest a different name for
impl(I had a hard time to figure out a good name :( )This will help us find a better folder to put future stuff in (e.g.,
local/).Link of any specific issues this addresses