Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize error message across remote runtime and eventstream runtime #4159

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

xingyaoww
Copy link
Contributor

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality that this introduces


Give a summary of what the PR does, explaining any non-trivial design decisions

Standardize error message to be the same as RemoteRuntime:

else:
error_message = response.text
logger.error(f'Error from server: {error_message}')
obs = ErrorObservation(f'Action execution failed: {error_message}')
except Timeout:
logger.error('No response received within the timeout period.')
obs = ErrorObservation('Action execution timed out')
except Exception as e:
logger.error(f'Error during action execution: {e}')
obs = ErrorObservation(f'Action execution failed: {str(e)}')


Link of any specific issues this addresses

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the title of the PR, there is no difference between remote and local already on the messages tweaked in the PR, is it?

Nevertheless, if it helps, let's tweak them.

@xingyaoww
Copy link
Contributor Author

@enyst yeah it was just a little annoying to grep for two different error message in the eval output 🤣

@xingyaoww xingyaoww merged commit d518ca0 into main Oct 2, 2024
14 checks passed
@xingyaoww xingyaoww deleted the xw/standardize-error-msg branch October 2, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants