Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Show messages' timestamp in UI #3869

Merged
merged 13 commits into from
Sep 16, 2024
Merged

(feat) Show messages' timestamp in UI #3869

merged 13 commits into from
Sep 16, 2024

Conversation

tobitege
Copy link
Collaborator

@tobitege tobitege commented Sep 14, 2024

Short description of the problem this fixes or functionality that this introduces. This may be used for the CHANGELOG

Added timestamp display for each chat message.


Give a summary of what the PR does, explaining any non-trivial design decisions

  • chat-related UI components and tests extended to take timestamp into account
  • aria-label for chat messages with translations for screen readers, like Message from Assistant
  • tweaks in backend for consistent datetime handling

TODO?

  • the date format of the user's browser or system should already be used, need confirmation from other regions
  • is extra styling needed? is the frontend code meeting standards?

Link of any specific issues this addresses

grafik

@tobitege tobitege added enhancement New feature or request frontend Related to frontend labels Sep 14, 2024
frontend/src/components/chat/ChatMessage.tsx Outdated Show resolved Hide resolved
frontend/src/components/chat/ChatMessage.tsx Outdated Show resolved Hide resolved
tests/unit/test_event_stream.py Outdated Show resolved Hide resolved
@tobitege
Copy link
Collaborator Author

How come the pre-commit doesn't run prettier on changed frontend files, but the workflow errors on them? grrr

@tobitege tobitege marked this pull request as draft September 15, 2024 17:18
@tobitege tobitege marked this pull request as ready for review September 15, 2024 18:03
@tobitege
Copy link
Collaborator Author

Thanks for all your expert advice, @amanape ! 🏅

@tobitege tobitege merged commit a33f61c into main Sep 16, 2024
14 checks passed
@tobitege tobitege deleted the tobitege/chat-timestamps branch September 16, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants