-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): UI overhaul #3604
Conversation
This is exciting!! 😍 |
@tobitege Thanks a lot for taking the time to provide a thorough review! This is all great feedback that I'll be adding to the backlog and pick them off one-by-one. To answer your questions:
Yes
You make a good point. I'll discuss this with Paul
No. They are new designs but we're still exploring alternatives here (or maybe go back to what it was).
Woops!
Thanks for pointing this out For the most part, these issues are non blocking and can be addressed in follow-up PRs (this one has already grown larger than it should have). Just a heads up that this may merge without all of these points resolved yet. |
Thanks for the feedback @tobitege! I agree with Stephan that some of these can be pushed into follow-up issues, especially the "long running" stuff :) The only one that sounds like a blocker to me is the settings modal bug--that seems worrisome |
Yes, it's mostly cosmetics I observed, no blockers to me. 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Quite a huge effort in this, thanks so much for all the work! 🥇
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Extends and improves the UI based on Paul's new and approved designs.
CHANGELOG
/app
Resolves #3447, #3755, #3584, #3683, #3736