Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: resolver example should use "max_iterations: ${{ fromJson(vars.OPENHANDS_MAX_ITER || 50) }}" #5263

Closed
1 task done
d-walsh opened this issue Nov 25, 2024 · 3 comments · Fixed by #5349
Closed
1 task done

[Bug]: resolver example should use "max_iterations: ${{ fromJson(vars.OPENHANDS_MAX_ITER || 50) }}" #5263

d-walsh opened this issue Nov 25, 2024 · 3 comments · Fixed by #5349
Labels
bug Something isn't working resolver Related to OpenHands Resolver

Comments

@d-walsh
Copy link
Contributor

d-walsh commented Nov 25, 2024

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

There is a bug where the the current code evaluates as a string and results in this:

OpenHands Resolver
The template is not valid. .github/workflows/openhands-resolver.yml (Line: 26, Col: 23): Unexpected value '100'

@openhands-agent

OpenHands Installation

Docker command in README

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

No response
@d-walsh d-walsh added the bug Something isn't working label Nov 25, 2024
@mamoodi mamoodi added the resolver Related to OpenHands Resolver label Nov 25, 2024
@kevin-support-bot kevin-support-bot bot mentioned this issue Nov 26, 2024
Open
@malhotra5 malhotra5 added the fix-me Attempt to fix this issue with OpenHands label Dec 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

OpenHands started fixing the issue! You can monitor the progress here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

A potential fix has been generated and a draft PR #5349 has been created. Please review the changes.

@openhands-agent openhands-agent mentioned this issue Dec 1, 2024
Merged
malhotra5 pushed a commit that referenced this issue Dec 1, 2024
@openhands-agent
Fix issue #5263: [Bug]: resolver example should use "max_iterations: …
59c57ac 
…${{ fromJson(vars.OPENHANDS_MAX_ITER || 50) }}" (#5349)
@malhotra5
Copy link
Contributor

Resolved by #5349; thanks for the catch @d-walsh!

@malhotra5 malhotra5 removed the fix-me Attempt to fix this issue with OpenHands label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working resolver Related to OpenHands Resolver
Projects
None yet
Milestone
No milestone
3 participants
@d-walsh @malhotra5 @mamoodi