feature: support multiple containerd-shim #2363
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
different runtime can have a specified containerd-shim, especially for
vm runtime like kata/runv.
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
what the pr want to do
First we see how pouch run a container,
pouch
->containerd
->containerd-shim
->runtime
. The PR specify the shim can be choosed for the runtime, this is useful for vm runtime like kata/runv, since vm containers have many different with runc container cause they running in a vm machine.containerd 1.2 have support a shim v2 API(containerd/containerd#2434), this allowed a runtime to specify itself shim, they can do more custom then.
what the PR status
The PR is compele finished in function, we pass a shim interface to containerd to choose the shim, this is supported by containerd 1.0.3, so it can be merged now, no need to wait for containerd 1.2. And all process in create container in pouch is keeping same.
TODO list
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews