Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-2024 cycle updates and more (after dev testing) #111

Merged
merged 16 commits into from
Sep 6, 2023
Merged

Conversation

AlisonLanski
Copy link
Owner

  • Gender reporting with small N masking
  • new 12 month enrollment high school section
  • ADM example with small N masking for gender reporting and test percentiles
  • syntax compatibility updates for tidyselect 1.2.0+
  • syntax compatibility updates for roxygen2 7.0.0+
  • cosmetic improvements

@AlisonLanski AlisonLanski self-assigned this Aug 19, 2023
@AlisonLanski
Copy link
Owner Author

re-check control flow for small N masking before approval

Copy link
Collaborator

@shilohfling shilohfling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me! I left a few comments.

Overall, I'm curious about why you switched the syntax in select() from .data$COLUMN_NAME to "COLUMN_NAME" but not in other functions? Did you find out that this is faster or is it just aesthetic?

.data$StudentId < 105 ~ 4, #another
dplyr::mutate(GenderDetail = dplyr::case_when(.data$StudentId < 103 ~ 3, #unknown UG (3)
.data$StudentId < 105 ~ 4, #another UG (2)
.data$StudentId > 154 ~ 4, #another GR (5)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the logic on the GenderDetail case_when() in the dummy data. What happens to StudentId's between 104 and 154? Why are the first two case statements < 103 and < 105?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we set the GenderDetail defaults to be the same as Sex above, and the student ID numbers range from 101-155, so this is setting the low numbers 101-103 as UNK UG level, 104-105 as ANO for UG and then the top numbers 154-155 as ANO for GR level. We ignore the middle because it stays as M (1) F(2).

R/create_dummy_data_e1d.R Show resolved Hide resolved
#remove any empty dfs (can happen from fall enrollment, 12 month enrollment, maybe others)
dfs %>%

purrr::discard(~ nrow(.x) == 0) %>%
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this so much!! This is a great addition!

@AlisonLanski
Copy link
Owner Author

The select $.data to "" is a change for select-related functions only and is based on a tidyverse update. It removes a bunch of warning messages :}

@shilohfling shilohfling merged commit 92069e5 into master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment