-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023-2024 cycle updates and more (after dev testing) #111
Conversation
AlisonLanski
commented
Aug 19, 2023
- Gender reporting with small N masking
- new 12 month enrollment high school section
- ADM example with small N masking for gender reporting and test percentiles
- syntax compatibility updates for tidyselect 1.2.0+
- syntax compatibility updates for roxygen2 7.0.0+
- cosmetic improvements
…; e1d fixed in main commit
…r small N in Gender or Exam columns
…S students with new data requirement/testing/etc
…with quotes within select and pivot - should be bkwds compatible
2023-2024 cycle update and other bug fixes
re-check control flow for small N masking before approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me! I left a few comments.
Overall, I'm curious about why you switched the syntax in select() from .data$COLUMN_NAME
to "COLUMN_NAME"
but not in other functions? Did you find out that this is faster or is it just aesthetic?
.data$StudentId < 105 ~ 4, #another | ||
dplyr::mutate(GenderDetail = dplyr::case_when(.data$StudentId < 103 ~ 3, #unknown UG (3) | ||
.data$StudentId < 105 ~ 4, #another UG (2) | ||
.data$StudentId > 154 ~ 4, #another GR (5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the logic on the GenderDetail case_when() in the dummy data. What happens to StudentId's between 104 and 154? Why are the first two case statements < 103 and < 105?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we set the GenderDetail defaults to be the same as Sex above, and the student ID numbers range from 101-155, so this is setting the low numbers 101-103 as UNK UG level, 104-105 as ANO for UG and then the top numbers 154-155 as ANO for GR level. We ignore the middle because it stays as M (1) F(2).
#remove any empty dfs (can happen from fall enrollment, 12 month enrollment, maybe others) | ||
dfs %>% | ||
|
||
purrr::discard(~ nrow(.x) == 0) %>% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this so much!! This is a great addition!
The select $.data to "" is a change for select-related functions only and is based on a tidyverse update. It removes a bunch of warning messages :} |