Adjust imap authenticate documentation #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ichdasich thank you for your contribution. Could you please amend your commit messages according to documentation https://github.com/Alinto/sogo/blob/master/.github/CONTRIBUTING.md ? |
|
Thanks, will take a look; Sorry, this was created in the middle of the night after a rather painfull debugging session, so i do not forget. ;-) |
|
No problem thanks for your support ! |
added 2 commits
November 8, 2022 13:41
forcing `AUTHENTICATE` using Add NGImap4AuthMechanism = "plain"; is necessary for setups where users have UTF-8 characters in their password
update documentation for NGImap4AuthMechanism to highlight that using `AUTHENTICATE` is necessary to allow users to have UTF-8 characters in their passwords, i.e., especially 'umlauts'.
ichdasich
force-pushed
the
adjust_imap_authenticate_documentation
branch
from
6da2d18 to
14608b1
Compare
|
Changed the messages, does this work? |
|
Nice ! Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request updates the default configuration file and the documentation to highlight that
NGImap4AuthMechanism = "plain";should be set to forceAUTHENTICATEusage if users' passwords may contain UTF-8 characters like umlauts.Otherwise, users may update their passwords via SOGo to ones containing an UTF-8 character, which then inadvertedly breaks the mail view, as logging in via
LOGINis no longer possible. Logging into SOGo itself still works, but users are presented with a white page when trying to access the mail view.Security Side Note: Depending on the setup it seems to be possible to lock up SOGo worker threads using this, ultimately leading to a DoS (as soon as all workers are busy for this user). Specifically, I just had one user on a small (20 worker threads) instance setting a password containing an umlaut. As the user tried to log in multiple times, ultimately all workers were busy with trying to authenticate to the IMAP server. I did not fully debug this, but there might also be some malicious potential in this for some malicious activity.