fix(preferences): Fix NSException issue when SOGoCreateIdentitiesDisa…

…bled is set
Alinto · Jun 20, 2023 · ef958f6 · ef958f6
1 parent 4177ec1
commit ef958f6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/SoObjects/SOGo/SOGoUser.m b/SoObjects/SOGo/SOGoUser.m
@@ -833,6 +833,7 @@ - (void) _appendSystemMailAccountWithDelegatedIdentities: (BOOL) appendDeletegat
             {
               // This additional identity should not appear in the identity manager of the Preferences
               [identity setObject: [NSNumber numberWithBool: YES] forKey: @"isReadOnly"];
+              [identity setObject: [NSNumber numberWithBool: NO] forKey: @"isDefault"];
             }
           [identities addObject: identity];
         }

diff --git a/UI/PreferencesUI/UIxPreferences.m b/UI/PreferencesUI/UIxPreferences.m
@@ -1348,6 +1348,7 @@ - (void) _extractMainAccountSettings: (NSDictionary *) account
   NSMutableArray *previousIdentities, *newIdentities;
   NSMutableDictionary *identity, *newIdentitiesAsDict;
   int i;
+  BOOL isDefault;
 
   if ([account isKindOfClass: [NSDictionary class]])
     {
@@ -1372,9 +1373,15 @@ - (void) _extractMainAccountSettings: (NSDictionary *) account
             // Remove existing deleted identities
             for (identity in [user allIdentities]) {
               // Identity deleted and at least one identity and not the default identity
+              if ([identity objectForKey:@"isDefault"]) {
+                isDefault = [[identity objectForKey:@"isDefault"] boolValue];
+              } else {
+                isDefault = NO;
+              }
+
               if (![newIdentitiesAsDict objectForKey: [identity objectForKey:@"email"]] 
                     && [previousIdentities count] > 1
-                    && ![identity boolForKey:@"isDefault"]) {
+                    && !isDefault) {
                 [previousIdentities removeObjectAtIndex: i];
                 i--;
               }